Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

128x64 full graphic smart controller support #14

Open
wants to merge 7 commits into
base: Release-Candidate
Choose a base branch
from
Open

128x64 full graphic smart controller support #14

wants to merge 7 commits into from

Conversation

Mylan719
Copy link

My ramps 1.4 came with a 12864 display as is often the case.
I thought it was a pitty that a very common display had been unsupported and I decided to implement support for it.

  • Has custom screen designed to resemble the original status screen for 2004 Smart LCD Controller
  • All menus work fine
  • Support for blob/filament sensor

image

Should solve #7

Mylan719 added 7 commits May 27, 2022 11:58
@Mylan719
Mackerel now compiles if full graphical is chosen
6d355ed 
- implemented lyman extruder greeting
@Mylan719
Status screen implemented
f62072f 
-full graphical display now displays all extrusion info.
@Mylan719
Changed the walue edit font for smaller
960ea44 
- many of longer descriptions did not fit.
@Mylan719
Refactored status screen code to make it nicer
71c916e
@Mylan719
Unified the look of setting menu with other menus.
4034258
@Mylan719
Fixed strange behavior of encoder
b1c6cf1 
- when using the full graphics dispaly
@Mylan719
Renamed "Winder RRPM Factor" to "Winder max RPM"
0401b0e 
- since it is clearer and shorter.
- shortened "ESteps/rev/100" to "Esteps/rev" the "/100" part did not fit on the display
@viveksadhwani
Copy link

@Mylan719
thanks for adding full graphic smart controller support

im new to github and want to download this code to see if the chance you've done is working

i can see the the chances you've done but cant find an option to download the code and just replace it with my current master version

whats the best way to download and check this pull request code ?

thanks

viveksadhwani
viveksadhwani reviewed Sep 25, 2022
View reviewed changes
Copy link

@viveksadhwani viveksadhwani left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

below is the error i faced while trying to implement this code

tried looking for Mackerel.h library in library manager

also tried to comment #include Mackerel.h but then face alot many other error, please let me know if you need other error after commeting #include Mackerel.h library

thanks

library include error.txt

viveksadhwani
viveksadhwani reviewed Sep 25, 2022
View reviewed changes
Copy link

@viveksadhwani viveksadhwani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

im sorry for the last comment i was assuming that im using a master copy of this project but actually i download my copy from https://www.artme-3d.de/extruder-mk1-en/

anyways i found some error while implement this code

thanks
error report.txt

@Mylan719
Copy link
Author

Mylan719 commented Oct 11, 2022 •
edited
Loading

@viveksadhwani

im sorry for the last comment i was assuming that im using a master copy of this project but actually i download my copy from https://www.artme-3d.de/extruder-mk1-en/

anyways i found some error while implement this code

thanks error report.txt

This pull request is meant for [Release-Candidate](https://github.com/filipmu/Marlin-Mackerel/tree/Release-Candidate) branch of this repository.
It will require changes if you wan to apply it as a patch to master branch. Master branch has no support for the "Blob sensor". This is why you are getting:
ultralcd.cpp:1007:37: error: 'blob_width_desired' was not declared in this scope
In master there is no variable blob_width_desired because there is no support for blob sensor. The support was added in the Release-Candidate branch.
I don't know if ARTME 3D has the blob support, their sources is modified, my changes may be incompatible.

Best way to get the changes is to:

  1. Install GIT
  2. do git clone https://github.com/Mylan719/Marlin-Mackerel.git clone my forked repo into directory of your choice
  3. then git checkout full-graphics-display checkout my full-graphics-display branch that contains the changes for full display
  4. now the sources should be version version
  5. verify you have U8glib library installed in your compiler of choice
  6. you should be able to build the sources

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@viveksadhwani viveksadhwani viveksadhwani left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Mylan719 @viveksadhwani